Docs: Improve readability on page Branching and Tagging #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
May 12, 2023
docs/branching-and-tagging.md
Outdated
| @@ -30,7 +30,7 @@ menu: | |||
|
|
|||
| ## Overview | |||
|
|
|||
| Iceberg table metadata maintains a log of snapshots which represent the changes applied to a table. | |||
| Iceberg table metadata maintains a lot of snapshots which represent the changes applied to a table. | |||
There was a problem hiding this comment.
I'm not sure this is a typo, I think this actually means that it's holding a snapshot log. To make this clearer maybe reword this to Iceberg table metadata maintains a snapshot log, which represent the changes applied to a table.
There was a problem hiding this comment.
@nastra Thanks for clarification. It seems that i misunderstood the sentence. :)
There was a problem hiding this comment.
Yeah it's a log of snapshots, but I like @nastra suggestion, we can use "snapshot log" so it's more clear. thanks @zhangbutao !
There was a problem hiding this comment.
I made a little change on this sentence according your guys suggestion. Thanks.
zhangbutao
changed the title
nastra
approved these changes
May 15, 2023
amogh-jahagirdar
approved these changes
May 15, 2023
|
Looks great, thanks @zhangbutao ! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve readability on the page: https://iceberg.apache.org/docs/latest/branching/