Core: Remove deprecated AssertHelpers usage #7597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
May 15, 2023
| .options(ImmutableMap.of(BinPackStrategy.MIN_INPUT_FILES, Long.toString(-5)))) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageStartingWith( | ||
| "Cannot set min-input-files is less than 1. All values less than 1 have the same effect as 1"); |
There was a problem hiding this comment.
Cannot set min-input-files is less than 1 is slightly misleading. Could you maybe open a separate PR to slightly improve the error messaging in BinPackStrategy?
There was a problem hiding this comment.
OK, i'll do this later~
|
thanks @liuxiaocs7 for cleaning this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AssertHelpers in iceberg-core module.