Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Allow one data writer in BasePositionDeltaWriter #7648

Merged
merged 1 commit into from
May 18, 2023
Merged

Core: Allow one data writer in BasePositionDeltaWriter #7648

merged 1 commit into from
May 18, 2023

Conversation

aokolnychyi
Copy link
Contributor

This PR allows using a single data writer in BasePositionDeltaWriter.

@aokolnychyi
Copy link
Contributor Author

@szehon-ho, could you check this out?

szehon-ho
szehon-ho approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@szehon-ho szehon-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For some general context, where will this be used?

@aokolnychyi
Copy link
Contributor Author

@szehon-ho, I am going to use this on the Spark side to write a delta where I want to produce only one data file.

@aokolnychyi aokolnychyi merged commit 4554938 into apache:master May 18, 2023
41 checks passed
@aokolnychyi
Copy link
Contributor Author

Thanks for reviewing, @szehon-ho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szehon-ho szehon-ho szehon-ho approved these changes

Assignees
No one assigned
Labels
core data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aokolnychyi @szehon-ho