Core: Add REST spec and request for committing changes against multiple tables #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
rest-only-for-multi-table-diff
branch
from
2e68517
to
67bef79
Compare
nastra
force-pushed
the
rest-only-for-multi-table-diff
branch
from
67bef79
to
7585a4e
Compare
nastra
force-pushed
the
rest-only-for-multi-table-diff
branch
from
7585a4e
to
71711e1
Compare
rdblue
reviewed
Jun 4, 2023
core/src/main/java/org/apache/iceberg/rest/requests/CommitTransactionRequest.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jun 4, 2023
| import org.immutables.value.Value; | ||
|
|
||
| @Value.Immutable | ||
| public interface CommitTransactionRequest extends RESTRequest { |
There was a problem hiding this comment.
Is this worth using Immutables?
This is straightforward as a simple object, and then callers don't need to know that there is a different implementation class they should use.
There was a problem hiding this comment.
I'm ok not using Immutables here, since it's a single field. We'll just end up with slightly more code than in the Immutables version but without another class being generated
rdblue
reviewed
Jun 4, 2023
core/src/test/java/org/apache/iceberg/rest/requests/TestCommitTransactionRequestParser.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jun 4, 2023
core/src/test/java/org/apache/iceberg/rest/requests/TestCommitTransactionRequestParser.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jun 4, 2023
core/src/test/java/org/apache/iceberg/rest/requests/TestCommitTransactionRequestParser.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jun 4, 2023
core/src/test/java/org/apache/iceberg/rest/requests/TestCommitTransactionRequestParser.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jun 4, 2023
core/src/main/java/org/apache/iceberg/rest/requests/UpdateTableRequest.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jun 9, 2023
core/src/main/java/org/apache/iceberg/rest/requests/CommitTransactionRequest.java
Show resolved
Hide resolved
rdblue
reviewed
Jun 9, 2023
core/src/main/java/org/apache/iceberg/rest/requests/CommitTransactionRequest.java
Show resolved
Hide resolved
rdblue
reviewed
Jun 9, 2023
core/src/main/java/org/apache/iceberg/rest/requests/CommitTransactionRequestParser.java
Show resolved
Hide resolved
rdblue
reviewed
Jun 9, 2023
| List<UpdateTableRequest.UpdateRequirement> requirements = Lists.newArrayList(); | ||
| List<MetadataUpdate> updates = Lists.newArrayList(); | ||
|
|
||
| if (node.hasNonNull(IDENTIFIER)) { |
There was a problem hiding this comment.
Is the plan to refactor this into an UpdateTableRequestParser? Seems strange to write this but not as a separate class for that request.
There was a problem hiding this comment.
yes that will be refactored into UpdateTableRequestParser in #7750
rdblue
approved these changes
Jun 9, 2023
|
Looks great, thanks for getting this done, @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #7569