-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix SQL formatting in Flink docs #7761
Conversation
@hililiwei @stevenzwu @Fokko @nastra @rdblue Hello, I am a contributor to iceberg for the first time. Could you please help me review it? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we revert changes to the getting started page
docs/flink-getting-started.md
Outdated
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: probably better to revert changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion, I have revert that file.
thanks @TaoZex for your contribution and welcome to the Iceberg community |
1.Fix URL link in flink-getting-started.md
Before:
After:
2.Fix docs format in flink-ddl.md
Before:
After: