Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix SQL formatting in Flink docs #7761

Merged
merged 9 commits into from
Jun 13, 2023
Merged

Docs: Fix SQL formatting in Flink docs #7761

merged 9 commits into from
Jun 13, 2023

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented Jun 3, 2023

1.Fix URL link in flink-getting-started.md
Before:
1685806883434
After:
9ad0fc83646b9595fcec533150e740c

2.Fix docs format in flink-ddl.md
Before:
d0ebe493d93bbf01d345eca3d3b15b5
After:
163ad880a116c75d7f2c13cfd57bbf5

@github-actions github-actions bot added the docs label Jun 3, 2023
@TaoZex TaoZex changed the title Docs: Fix URL link in flink-getting-started Docs: Fix flink docs format Jun 4, 2023
@TaoZex
Copy link
Contributor Author

TaoZex commented Jun 12, 2023

@hililiwei @stevenzwu @Fokko @nastra @rdblue Hello, I am a contributor to iceberg for the first time. Could you please help me review it? Thank you.

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we revert changes to the getting started page

*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: probably better to revert changes to this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion, I have revert that file.

@nastra nastra changed the title Docs: Fix flink docs format Docs: Fix SQL formatting in Flink docs Jun 13, 2023
@nastra
Copy link
Contributor

nastra commented Jun 13, 2023

thanks @TaoZex for your contribution and welcome to the Iceberg community

@nastra nastra merged commit 50fefe4 into apache:master Jun 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants