Core: Generate Builder for UpdateTableRequest #7838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Jun 14, 2023
|
|
||
| @Value.Style(newBuilder = "newBuilder") |
There was a problem hiding this comment.
without this, one would instantiate the Builder via new UpdateTableRequestBuilder(), which is probably fine as well. We could also add
public static UpdateTableRequestBuilder builder() {
return new UpdateTableRequestBuilder();
}
to UpdateTableRequest
nastra
commented
Jun 14, 2023
| public UpdateTableRequest(List<UpdateRequirement> requirements, List<MetadataUpdate> updates) { | ||
| this.requirements = requirements; | ||
| this.updates = updates; | ||
| } | ||
|
|
||
| @Constructor |
There was a problem hiding this comment.
this will generate a Builder class from the constructor params and we're indicating in the constructor that TableIdentifier can be null.
There was a problem hiding this comment.
the constructor needs to be non-private (we could also change it to protected to be more strict and force usage via the generated builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've mainly opened this PR as a discussion point to have an alternative to writing manual builders for classes that we can't or don't want to switch to
@Value.Immutable.The Immutables lib can also be used to generate a Builder without having to annotate a class with
@Value.Immutable. It's worth mentioning that this is mainly for use cases where we don't require additional processing logic in the builders.