Core: Migrate jdbc package to JUnit5 #7874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Jun 22, 2023
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcTableConcurrency.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcTableConcurrency.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcTableConcurrency.java
Outdated
Show resolved
Hide resolved
nastra
changed the title
nastra
changed the title
|
Updated PR with the review changes. |
nastra
reviewed
Jun 23, 2023
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcTableConcurrency.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Jun 23, 2023
|
@nastra Can this be merged now? I don't have merge access so I can't merge it to the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to the issue "Move JUnit4 tests to JUnit5 #7160 ".