Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Partitions table in Flink/Spark doc #8021

Merged
merged 3 commits into from Jul 13, 2023

Conversation

hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Jul 9, 2023

Note

@github-actions github-actions bot added the docs label Jul 9, 2023
docs/flink-queries.md Outdated Show resolved Hide resolved

Note:
1. For unpartitioned tables, the partitions table will contain only the record_count and file_count columns.
1. For unpartitioned tables, the partitions table will not contain partition and spec_id field.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry another nit, field should be plural:

  1. For unpartitioned tables, the partitions table will not contain the partition and spec_id fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


Note:
For unpartitioned tables, the partitions table will contain only the record_count and file_count columns.
For unpartitioned tables, the partitions table will not contain the partition and spec_id fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, i just noticed original word is columns but we updated to use fields here. do you think fields are better?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. dont have a strong opinion, I guess they are both equivalent, or do you see a difference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right, looking at spec and they are used interchangeably

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dramaticlly Thanks for your feedback:)

Copy link
Contributor

@dramaticlly dramaticlly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hsiang-c , this include doc update for many improvements we did on partitions table!


Note:
For unpartitioned tables, the partitions table will contain only the record_count and file_count columns.
For unpartitioned tables, the partitions table will not contain the partition and spec_id fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right, looking at spec and they are used interchangeably

@szehon-ho szehon-ho merged commit 31dd70c into apache:master Jul 13, 2023
2 checks passed
@szehon-ho
Copy link
Collaborator

Merged, thanks @hsiang-c , and @dramaticlly for extra review!

@hsiang-c hsiang-c deleted the doc_partitions branch July 14, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants