New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update Partitions table in Flink/Spark doc #8021
Conversation
docs/spark-queries.md
Outdated
|
||
Note: | ||
1. For unpartitioned tables, the partitions table will contain only the record_count and file_count columns. | ||
1. For unpartitioned tables, the partitions table will not contain partition and spec_id field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry another nit, field should be plural:
- For unpartitioned tables, the partitions table will not contain the partition and spec_id fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
||
Note: | ||
For unpartitioned tables, the partitions table will contain only the record_count and file_count columns. | ||
For unpartitioned tables, the partitions table will not contain the partition and spec_id fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, i just noticed original word is columns but we updated to use fields here. do you think fields are better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. dont have a strong opinion, I guess they are both equivalent, or do you see a difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you are right, looking at spec and they are used interchangeably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dramaticlly Thanks for your feedback:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hsiang-c , this include doc update for many improvements we did on partitions table!
|
||
Note: | ||
For unpartitioned tables, the partitions table will contain only the record_count and file_count columns. | ||
For unpartitioned tables, the partitions table will not contain the partition and spec_id fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you are right, looking at spec and they are used interchangeably
Merged, thanks @hsiang-c , and @dramaticlly for extra review! |
Note