GCP: fix single byte read in GCSInputStream #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweeks
approved these changes
Jul 15, 2023
| @@ -117,7 +117,7 @@ public int read() throws IOException { | |||
| readBytes.increment(); | |||
| readOperations.increment(); | |||
|
|
|||
| return singleByteBuffer.array()[0]; | |||
| return singleByteBuffer.array()[0] & 0xFF; | |||
There was a problem hiding this comment.
Should we use Byte.toUnsignedInt() here to be more clear?
nastra
approved these changes
Jul 15, 2023
| @@ -117,7 +117,7 @@ public int read() throws IOException { | |||
| readBytes.increment(); | |||
| readOperations.increment(); | |||
|
|
|||
| return singleByteBuffer.array()[0]; | |||
| return singleByteBuffer.array()[0] & 0xFF; | |||
nastra
pushed a commit
to nastra/iceberg
that referenced
this pull request
Aug 15, 2023
* Spark: Update antlr4 to match Spark 3.4 (apache#7824) * Parquet: Revert workaround for resource usage with zstd (apache#7834) * GCP: fix single byte read in GCSInputStream (apache#8071) * GCP: fix byte read in GCSInputStream * add test * Parquet: Cache codecs by name and level (apache#8182) * GCP: Add prefix and bulk operations to GCSFileIO (apache#8168) * AWS, GCS: Allow access to underlying storage client (apache#8208) * spotless
|
@bryanck Thank you for fixing this! It stymied my efforts to try to use GCSFileIO for several weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the conversion of a byte to an int when reading a single byte from GCSInputStream. Decoding integers in Parquet was throwing an exception because of this, in this method.