New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: support config storage class for S3FileIO #8154
Conversation
@nastra please help review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense, but I think we need to do the same for initializeMultiPartUpload()
. Can you please add some tests to TestS3FileIOProperties
?
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
Outdated
Show resolved
Hide resolved
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java
Outdated
Show resolved
Hide resolved
@nastra hi, we have refined the unit tests of TestS3FileIOProperties, please help review |
hi @nastra I added a spotlessApply |
Thanks @gegef2009 |
AWS: support config storage class for S3FileIO , to solve issue: #8153