-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iceberg-spark changes for vectorized reads #828
Conversation
spark/src/main/java/org/apache/iceberg/spark/arrow/ArrowUtils.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReaders.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReaders.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReaders.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/arrow/ArrowUtils.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/arrow/ArrowUtils.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/InternalRowTaskDataReader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/ColumnarBatchTaskDataReader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
Outdated
Show resolved
Hide resolved
I just ran a test with non-dictionary data using all supported primitives and 100 million records and it passed. That, combined with mostly good coverage gives me a lot of confidence that this is (mostly) correct. Nice work, @samarthjain! |
Looks like the failures are checkstyle violations:
|
a3dd1ce
to
3c9cc06
Compare
} | ||
|
||
protected int getNumRows() { | ||
return NUM_ROWS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make this a method? So it can be overridden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
951812f
to
2fed825
Compare
Summary of changes: 1) Below new test cases added: - Test for code path when optional values are mostly null - Test for case when containers are not reused for every batch - Test for case to verify arrow's validity vector is set correctly when setArrowValidityVector = true 2) Reuse container logic is now similar to row based read path 3) We now always set the nullability holder. Arrow validity vector is set only for purpose of supplying complete arrow vectors when requested to do so.
2fed825
to
24161c7
Compare
Thanks for all the hard work, @samarthjain! I think this is ready to merge. |
No description provided.