Core: Default to exponential retry strategy in REST client #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Aug 22, 2023
core/src/main/java/org/apache/iceberg/rest/ExponentialHttpRequestRetryStrategy.java
Show resolved
Hide resolved
nastra
force-pushed
the
http-client-retry-behavior
branch
3 times, most recently
from
86fcb68
to
2c0c7a9
Compare
rdblue
reviewed
Aug 22, 2023
core/src/main/java/org/apache/iceberg/rest/ExponentialHttpRequestRetryStrategy.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Aug 22, 2023
nastra
changed the title
nastra
force-pushed
the
http-client-retry-behavior
branch
from
78449e1
to
adb4636
Compare
bryanck
reviewed
Sep 13, 2023
| @@ -96,6 +99,9 @@ private HTTPClient( | |||
| clientBuilder.addRequestInterceptorLast(requestInterceptor); | |||
| } | |||
|
|
|||
| int maxRetries = PropertyUtil.propertyAsInt(properties, REST_MAX_RETRIES, 5); | |||
There was a problem hiding this comment.
This is a higher retry count than before with the default (which is 1 retry I believe), just wanted to double check that was the intent.
There was a problem hiding this comment.
yes this was the intent to increase the retry
nastra
force-pushed
the
http-client-retry-behavior
branch
2 times, most recently
from
c0d59bd
to
095acf0
Compare
nastra
force-pushed
the
http-client-retry-behavior
branch
from
095acf0
to
45fcd7d
Compare
rdblue
approved these changes
Sep 14, 2023
|
Thanks, @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new retry strategy, allowing exponential backoff and also allows to adjust the number of retries for the
DefaultHttpRequestRetryStrategy