Nessie: Provide better commit message on table registation #8331 #8385
Conversation
| @@ -513,6 +513,8 @@ private String buildCommitMsg(TableMetadata base, TableMetadata metadata, String | |||
| "Iceberg %s against %s", metadata.currentSnapshot().operation(), tableName); | |||
| } else if (base != null && metadata.currentSchemaId() != base.currentSchemaId()) { | |||
| return String.format("Iceberg schema change against %s", tableName); | |||
| } else if (base == null) { | |||
| return String.format("Iceberg table registered with name %s", tableName); | |||
There was a problem hiding this comment.
Does create table also enter this flow? 🤔
There was a problem hiding this comment.
Yes it does, sharing an example effect of this change:
There was a problem hiding this comment.
So, we can't differentiate create table and register flow?
If there is no way, I am ok with having this commit message (which was better than previous)
There was a problem hiding this comment.
IMO registered has a special meaning, I'd favor created/registered instead of just registered
There was a problem hiding this comment.
Thanks, changed the message likewise created/registered instead of just registered.
So, we can't differentiate create table and register flow?
The nearest possibility is to consider the case ascreateif there are no snapshots in the new metadata. Since it may not always be true, not pursuing that path.
|
|
|
This PR has been in review for a while now. Is there anything I can do to make things move on this track? |
|
Resolves #8331 |
|
PR title we don't mention issue number. Just a style that Iceberg follows. |
|
@nastra will need your help with the merge. |
Small change covering the registration time commit message when the catalog is Nessie.
Fixes #8331