Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.4: Set metricsReporter for CopyOnWriteScan/MergeOnReadScan/IncrementalAppendScan/ChangelogScan #8445

Merged
merged 1 commit into from Sep 14, 2023

Conversation

wForget
Copy link
Member

@wForget wForget commented Aug 31, 2023

close #8444

test sql:

CREATE TABLE wangzhen_test_iceberg_20230824_t3 (id bigint, name string)
USING iceberg;

INSERT INTO wangzhen_test_iceberg_20230824_t3 VALUES (4, 'd'),(5, 'e'),(6, 'f');
delete from wangzhen_test_iceberg_20230824_t3 where id = 5;

ui before:
image

after:
after

@github-actions github-actions bot added the spark label Aug 31, 2023
Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good find @wForget , thanks for the fix. I'll wait for @aokolnychyi @RussellSpitzer and others to provide their inputs

@ConeyLiu
Copy link
Contributor

ConeyLiu commented Sep 1, 2023

Just curious, Is the after picture correct? Why a table with just three records can scan 41 manifests?

@wForget
Copy link
Member Author

wForget commented Sep 1, 2023

Just curious, Is the after picture correct? Why a table with just three records can scan 41 manifests?

I repeatedly executed INSERT and DELETE statement while debugging. I re-executed it using a new table and the result was correct.

image

Copy link
Contributor

@ConeyLiu ConeyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wForget wForget changed the title Set metricsReporter for CopyOnWriteScan/MergeOnReadScan/IncrementalAppendScan/ChangelogScan Spark 3.4: Set metricsReporter for CopyOnWriteScan/MergeOnReadScan/IncrementalAppendScan/ChangelogScan Sep 1, 2023
@aokolnychyi
Copy link
Contributor

@wForget, this looks good to me. Can we follow up with a few tests, similar to what was done for regular scans?

@aokolnychyi aokolnychyi merged commit 8fcc891 into apache:master Sep 14, 2023
31 checks passed
@aokolnychyi
Copy link
Contributor

Thanks, @wForget! Thanks for reviewing, @amogh-jahagirdar @ConeyLiu!

@wForget
Copy link
Member Author

wForget commented Sep 15, 2023

@wForget, this looks good to me. Can we follow up with a few tests, similar to what was done for regular scans?

@aokolnychyi Thanks, I will try to add relevant test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CopyOnWriteScan missing custom metrics
4 participants