Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add __repr__ method to Table class #8447

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

tlm365
Copy link
Contributor

@tlm365 tlm365 commented Aug 31, 2023

This PR add __repr__ method to the Table class.

@Fokko
Copy link
Contributor

Fokko commented Sep 1, 2023

Looking good @manhtaile Can you add a test as well?

@Fokko Fokko self-requested a review September 1, 2023 14:13
@tlm365
Copy link
Contributor Author

tlm365 commented Sep 1, 2023

@Fokko I'm sorry I forgot to write the test case, I've added and updated PR, thanks

@Fokko
Copy link
Contributor

Fokko commented Sep 20, 2023

@manhtaile Thanks for the PR, it looks great! Can you add the sort order as well?

@tlm365
Copy link
Contributor Author

tlm365 commented Sep 21, 2023

@Fokko of course, I added it to the repr

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for working on this @manhtaile

@Fokko Fokko merged commit bc71976 into apache:master Sep 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants