Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Enable strict metadata cleanup by default #8599

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Core: Enable strict metadata cleanup by default #8599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/java/org/apache/iceberg/TableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,10 @@ default long newSnapshotId() {
* Whether to clean up uncommitted metadata files only when a commit fails with a {@link
* CleanableFailure} exception.
*
* <p>This defaults to false: any unexpected exception will cause metadata files to be cleaned up.
* <p>This defaults to true: cleanup will only occur for exceptions marked as {@link
* CleanableFailure}
*/
default boolean requireStrictCleanup() {
return false;
return true;
}
}
5 changes: 0 additions & 5 deletions core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,4 @@ public long newSnapshotId() {
}
};
}

@Override
public boolean requireStrictCleanup() {
return true;
}
}