Dell : Migrate Files using TestRule to Junit5. #8707
Conversation
| import org.junit.runners.model.Statement; | ||
| import org.junit.jupiter.api.extension.AfterEachCallback; | ||
| import org.junit.jupiter.api.extension.BeforeEachCallback; | ||
| import org.junit.jupiter.api.extension.ExtensionContext; | ||
|
|
||
| /** | ||
| * Mock rule of ECS S3 mock. |
There was a problem hiding this comment.
nit: should we update the javadoc too?
There was a problem hiding this comment.
I am thinking of adding these annotations in this section ? Does that help or there's some other place I need to update in?
There was a problem hiding this comment.
as part of this PR I think what makes sense is to change the javadoc here from Mock rule of ECS S3 mock to Test extension for using an ECS S3 mock
There was a problem hiding this comment.
We can also update the class name from EcsS3MockRule to EcsS3MockExtension at all the places for better readability.
|
|
||
| @Override | ||
| public void beforeEach(ExtensionContext extensionContext) { | ||
| System.out.println("Bucket removed"); |
There was a problem hiding this comment.
It seems here we are trying to initialise the bucket.
There was a problem hiding this comment.
@nk1506 if there are no feedbacks, are we good to merge this?
|
Hi @nastra, Please provide your feedbacks on the PR for this issue. |
build.gradle
Outdated
| @@ -912,7 +912,6 @@ project(':iceberg-dell') { | |||
| implementation project(':iceberg-common') | |||
| implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow') | |||
| compileOnly libs.object.client.bundle | |||
|
|
|||
|
|
||
| @Override | ||
| public void afterEach(ExtensionContext extensionContext) { | ||
| System.out.println("Bucket removed"); |
There was a problem hiding this comment.
I would remove those println statements
build.gradle
Outdated
| @@ -987,5 +987,4 @@ String getJavadocVersion() { | |||
| apply from: 'jmh.gradle' | |||
| apply from: 'baseline.gradle' | |||
| apply from: 'deploy.gradle' | |||
| apply from: 'tasks.gradle' | |||
|
|
|||
| apply from: 'tasks.gradle' | |||
build.gradle
Outdated
| @@ -988,4 +988,3 @@ apply from: 'jmh.gradle' | |||
| apply from: 'baseline.gradle' | |||
| apply from: 'deploy.gradle' | |||
| apply from: 'tasks.gradle' | |||
|
|
|||
There was a problem hiding this comment.
looks like this still has a diff
Description
Closes #7888.
This PR updates some of the test files in dell package which uses
@Rule,@ClassRuleorextend TestRuleto Junit5.