Docs: Fix missing semicolons in SQL snippets. #8748
Conversation
Add a missing semicolon to the "CREATE TABLE ..." statement.
Priyansh121096
changed the title
|
No worries @Fokko. Stumbled upon this while blindly copy pasting from the getting started page and thought I'd put in a fix. Btw, I've also raised apache/iceberg-docs#281. I'm not sure which is the one that actually gets deployed to https://iceberg.apache.org/docs/latest/getting-started/. |
| @@ -69,7 +69,7 @@ To create your first Iceberg table in Spark, use the `spark-sql` shell or `spark | |||
|
|
|||
| ```sql | |||
| -- local is the path-based catalog defined above | |||
| CREATE TABLE local.db.table (id bigint, data string) USING iceberg | |||
| CREATE TABLE local.db.table (id bigint, data string) USING iceberg; | |||
There was a problem hiding this comment.
Can you please look up ```sql in the code and fix all the places? I found few more places in the docs like this.
There was a problem hiding this comment.
Sure, will do.
There was a problem hiding this comment.
@ajantha-bhat, this is done.
There was a problem hiding this comment.
Would be even better to have some kind of linter for this
There was a problem hiding this comment.
@Fokko Agreed.
.md files are modified in this repo and referred from iceberg-docs repo. So, fixing here is enough. Thumb rule is that if you find the docs in iceberg repo, fix here. If the doc is present only in iceberg-docs repo. Fix only in iceberg-doc repo. |
- And a couple of minor typo/brevity fixes.
Priyansh121096
changed the title
There was a problem hiding this comment.
LGTM. It is good to have this.
Even examples in Spark docs (https://spark.apache.org/docs/latest/sql-ref-syntax.html) follows semicolon syntax
|
Great work @Priyansh121096 If we find more we can create a new PR. (I also noticed that some blocks start with: For consistency it would be nice to have everything lowercase, but I think that works as well. |
|
Thanks @Fokko! This was my first contribution to apache/iceberg. Hope to make many more in the future. |
Add a missing semicolon to the "CREATE TABLE ..." statement.