Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Enable column statistics filtering after planning #8803
Core: Enable column statistics filtering after planning #8803
Changes from 7 commits
5bb425d
7a3effa
ae5975c
be9a11e
c8061f3
d0fcac2
9872f1f
f6279d0
32d2645
1922ae0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how I feel about supporting
null
here. Let me think.Also, won't the current implementation throw an exception if we pass
null
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not support null here as a valid value independently of what we will do in
ContentFile
. I would drop the doc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess that the situation is the similar with the other
@Nullable
TableScanContext
attributes, like:We have an undefined default behaviour which could be archived with not setting the values, or setting them to
null
. The only difference here is that we define this default behaviour. For consistency's sake we can remove the comment, but the behaviour will remain the same.Do I miss something?
Thanks for the detailed review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may consider overloading the constructor so that you don't have to pass an extra null here or adding the comment for the second argument (we have a comment for
true
but notnull
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this usage is straightforward, and adding a new constructor would not help too much.
So I did not apply this change