Core: Reduce unnecessary add operations in deletedPaths set

[bknbkn]

This change will make deletedPaths call 'add' function only if it not contains file path, thus avoiding the unnecessary cost caused by 'add' function calls

[bknbkn]

cc @RussellSpitzer. @rdblue. @aokolnychyi, may I request your assistance in enabling workflows approval? Thanks for your time.

[RussellSpitzer]

Not sure I understand this change. Seems like you are removing an optimization to avoid re computing whether a path is deleted if we already determined it is deleted?

[bknbkn]

Not sure I understand this change. Seems like you are removing an optimization to avoid re computing whether a path is deleted if we already determined it is deleted?

In the original code, the deletedPath.add() function is called regardless of whether the path is already in the deletedPath set. I think it only needs to be called when the path is not in the deletedPath set, if the path is already in the deletedPath set, calling the deletedPath.add() function will add nothing and is also unnecessary.

[RussellSpitzer]

What about the check on 422?

[bknbkn]

What about the check on 422?

sorry, I made a mistake in the previous comment. The change is about deletedPath, not deletePath, and only affects the code starting from line 443. It has been corrected now. Please take another look.

[amogh-jahagirdar]

This change looks good to me