Add sort_order_id to SCAN_COLUMNS to address null sort order ID in p… #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fokko Could you take a look on this fix ? Thanks a lot! |
rice668
force-pushed
the
sort_order_id
branch
from
05d3a9f
to
2396455
Compare
nastra
reviewed
Oct 19, 2023
nastra
reviewed
Oct 19, 2023
rice668
force-pushed
the
sort_order_id
branch
from
2396455
to
5bda371
Compare
|
@nastra Could you please take a look again ? Thanks . |
Fokko
approved these changes
Oct 19, 2023
nastra
approved these changes
Oct 19, 2023
… planned data files
rice668
force-pushed
the
sort_order_id
branch
from
5bda371
to
89a6162
Compare
rice668
changed the title
|
thanks for fixing this @zhangminglei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lanned data files
Fix #8864