Open-API: Error response in the spec don’t align with the expected model.

[geruh]

When generating a REST client using the current OpenAPI specification, the non-200 Iceberg error responses are defined as:

{
  "message": "Malformed request",
  "type": "BadRequestException",
  "code": 400
}

However, the provided examples in the spec correctly enclose the error details within an error JSON node:

{
  "error": {
    "message": "Malformed request",
    "type": "BadRequestException",
    "code": 400
  }
}

Iceberg error responses point to the ErrorModel as their schema, as seen here. Following the current convention and returning the above-stated non-200 error structure to the client results in a precondition failure within the ErrorResponseParser. This is due to the parsers expectation for all error responses to be wrapped within the error JSON node.

example: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L2444

Testing

make lint
OK

[jackye1995]

cc @amogh-jahagirdar @nastra seems like a miss in the spec, unless the OpenAPI error response requires the error nesting by default, but I did not find any reference of that.

[Fokko]

LGTM, thanks for fixing this @geruh

[Fokko]

👍

This is in line with the PyIceberg implementation:

class ErrorResponseMessage(IcebergBaseModel):
    message: str = Field()
    type: str = Field()
    code: int = Field()


class ErrorResponse(IcebergBaseModel):
    error: ErrorResponseMessage = Field()

[jackye1995]

looks good to me!

[jackye1995]

thanks for the fix, and thanks for the reviews!