Docs: Remove UNIQUE keyword as it is not supported in Flink #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvary Please review this when you have time. Thanks. |
|
cc @pvary @stevenzwu |
pvary
reviewed
Nov 21, 2023
docs/flink-writes.md
Outdated
| @@ -69,7 +69,7 @@ Iceberg supports `UPSERT` based on the primary key when writing data into v2 tab | |||
|
|
|||
| ```sql | |||
| CREATE TABLE `hive_catalog`.`default`.`sample` ( | |||
| `id` INT UNIQUE COMMENT 'unique id', | |||
| `id` INT COMMENT 'unique id', | |||
There was a problem hiding this comment.
nit: Could we remove the extra space after the column name too?
There was a problem hiding this comment.
Thanks for reviewing. Have removed the extra space.
pvary
approved these changes
Nov 23, 2023
|
Thanks for the fix @PrabhuJoseph! |
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UNIQUE keyword as it is not supported in Flink.