Flink: Adds support for 1.18 version #9211
Conversation
rodmeneses
force-pushed
the
adds_118_support
branch
from
3f27ded
to
890a7ae
Compare
stevenzwu
changed the title
| @@ -416,7 +416,7 @@ private static void assertAvroEquals( | |||
| Collection<?> expectedArrayData = (Collection<?>) expected; | |||
| ArrayData actualArrayData; | |||
| try { | |||
| actualArrayData = (ArrayData) actual; | |||
| actualArrayData = convertToArray(actual); | |||
There was a problem hiding this comment.
is this a behavior change from 1.18? it seems like a breaking change to me.
There was a problem hiding this comment.
only on 1.18 and it only affects the unit tests
There was a problem hiding this comment.
I know you only updated the unit test. but it suggests that Flink RowData field has changed from ArrayData to the raw type array (like int[]). I am trying to understand if it has any impact on compatibility.
There was a problem hiding this comment.
I know you only updated the unit test. but it suggests that Flink
RowDatafield has changed fromArrayDatato the raw type array (likeint[]). I am trying to understand if it has any impact on compatibility.
Thanks! cc: @pvary
There was a problem hiding this comment.
Based on @PrabhuJoseph's comment the changes are caused by https://issues.apache.org/jira/browse/FLINK-33523.
Based on the jira, this is an expected general fix in Flink 1.18.
There was a problem hiding this comment.
With the clarify from the discussion thread that @pvary started, I am good with following up on this one separately when Flink 1.18.1 is released
rodmeneses
force-pushed
the
adds_118_support
branch
from
890a7ae
to
8350780
Compare
rodmeneses
force-pushed
the
adds_118_support
branch
from
8350780
to
a163c98
Compare
|
thanks @rodmeneses for the contribution and @pvary for following up with the Flink community |
|
@rodmeneses: Could you please update the docs in a follow-up PR too? Here are the supported Flink versions: https://iceberg.apache.org/multi-engine-support/#apache-flink |
|
Hi, just to let you know that trying to download the runtime jar for the 1.18 version of Flink from https://iceberg.apache.org/multi-engine-support/#apache-flink returns a 404. EDIT: Wrong link. |
|
@andrea-zanetti Could you share the proper link? i cant find the Jar Runtime for 1.18 |
|
Hi @FranMorilloAWS, I have the same exact problem: cannot find it on maven central, got here via google search but the download link is broken. |
|
|
@andrea-zanetti, @FranMorilloAWS: Iceberg 1.5.0 will be the first version which supports Flink 1.18.x. It will be released soon, as the release process is already started |
|
Hi, Thanks for you answer. I'll wait for the release of the new version. |
No description provided.