Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.x] Core: Expired Snapshot files in a transaction should be deleted #9223

Merged
merged 2 commits into from Dec 19, 2023

Commits on Dec 5, 2023

  1. Core: Expired Snapshot files in a transaction should be deleted. (apa…

    …che#9183)
    
    When a snapshot is expired as part of a transaction, the manifest list
    file(s) should be deleted when the transaction commits. A recent change
    (apache#6634) ensured that these files are not deleted when they have also
    been committed as part of a transaction, but this breaks the simple
    case where no new files are committed. Fix this by not skipping
    deletion when the list of committed files is empty.
    
    TESTING:
    
    Extended a unit test to ensure that manifest list files are deleted.
    Ran the test without the fix on a branch where apache#6634 was reverted
    to show that this is a regression.
    bartash committed Dec 5, 2023
    Copy the full SHA
    bdf4274 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Core: Fix logic for determining set of committed files in BaseTransac…

    …tion when there are no new snapshots (apache#9221)
    amogh-jahagirdar authored and bartash committed Dec 6, 2023
    Copy the full SHA
    10aa6f4 View commit details
    Browse the repository at this point in the history