AWS: Add S3 Access Grants Integration #9385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
reviewed
Dec 28, 2023
jackye1995
reviewed
Dec 28, 2023
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 3, 2024
aws/src/main/java/org/apache/iceberg/aws/s3/S3AccessGrantsPluginConfigurations.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 3, 2024
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 3, 2024
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 4, 2024
aws/src/main/java/org/apache/iceberg/aws/s3/S3AccessGrantsPluginConfigurations.java
Outdated
Show resolved
Hide resolved
|
Seems like this is not getting much attraction from other reviewers. Given it is a pretty straightforward plugin integration, I will go ahead to merge it. We can fix things later if necessary. This also opens the question that if there is any other valuable plugins that we should consider adding integrations, we can do a search afterwards. Thanks for the work! |
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to add support for S3 Access Grants (S3AG) to S3FileIO through adding a new SDK Plugin (https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/kafkaconnect/model/Plugin.html) for S3 Access Grants (https://github.com/aws/aws-s3-accessgrants-plugin-java-v2). We are only adding the S3 Access Grants Plugin (which is available publicly on Maven) to the S3 Client Factory if the users enable S3AG on the catalog.
The additional options added in this CR mirror EMR's options for enabling S3AG support on EMR: https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-access-grants.html#emr-access-grants-launch-ec2. The only difference in experience between Iceberg and EMR (in general) is the fact that S3AG must be enabled individually per Iceberg catalog. This is as a result of a lack of infrastructure in Iceberg to allow user configurations across catalogs for AWS Client level configurations. We are not aiming to re-architect Iceberg for this change - we only want to add support through whatever existing mechanisms already exist.