Spark 3.5: Migrate tests in SQL directory to JUnit5 #9401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Jan 5, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/PartitionedWritesTestBase.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 6, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 6, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestPartitionedWritesAsSelect.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 6, 2024
| scalarSql("SELECT count(*) FROM %s", newTableName)); | ||
| assertThat(scalarSql("SELECT count(*) FROM %s", newTableName)) | ||
| .as("Should have " + values.size() + " row") | ||
| .isEqualTo((long) values.size()); |
There was a problem hiding this comment.
no, not needed. Will update this too.
There was a problem hiding this comment.
looking at the failed tests, we apparently do need the casts.
Line 48 shows in the schema, the id is a long.
private static final Schema schema =
new Schema(
Types.NestedField.required(1, "id", Types.LongType.get()),
Types.NestedField.required(2, "ts", Types.TimestampType.withoutZone()),
Types.NestedField.required(3, "tsz", Types.TimestampType.withZone()));
scalarSql() returns the id of the row. As its a long, we should continue using the casts.
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTable.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTableAsSelect.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 8, 2024
|
Thanks for the review, @nastra! I've made the suggested changes |
nastra
approved these changes
Jan 10, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the tests in spark/sql directory to JUnit5.
Issue: #9086