Nessie: Strip trailing slash for warehouse location #9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Jan 5, 2024
| @@ -183,7 +184,8 @@ private String validateWarehouseLocation(String name, Map<String, String> catalo | |||
| catalogOptions); | |||
| throw new IllegalStateException("Parameter 'warehouse' not set, Nessie can't store data."); | |||
| } | |||
| return warehouseLocation; | |||
|
|
|||
| return LocationUtil.stripTrailingSlash(warehouseLocation); | |||
There was a problem hiding this comment.
Just making this inline with other catalogs.
We can lookup the callers of LocationUtil.stripTrailingSlash
ajantha-bhat
commented
Jan 5, 2024
| public void testWarehouseLocationWithTrailingSlash() { | ||
| Assertions.assertThat(catalog.defaultWarehouseLocation(TABLE)) | ||
| .startsWith( | ||
| LocationUtil.stripTrailingSlash(temp.toUri().toString()) |
There was a problem hiding this comment.
This testcase was failing without the fix as temp.toUri() was having trailing slash which was leading to double slash in the path.
nastra
approved these changes
Jan 5, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other catalogs does the same and for some file system double slash in a path creates the problem.