-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flink: Remove reading of the data files to fix flakiness #9451
Conversation
@stevenzwu: I can not reproduce the issue locally. The actual reading of the data is not part of the Flink side test for WA. The tests are just checking the metrics there. Probably it would be enough on our side as well. Let's try out if this is still flaky, or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a different kind of flakiness than the class loader check.
I doubt we will still have flakiness as long as the following exists CommonTestUtils.waitForAllTaskRunning(
miniClusterResource.getMiniCluster(), jobClient.getJobID(), false); |
I have seen the classloader issue in a CI run yesterday. That code contained the I am really confused, because I couldn't reproduce the issue in any way locally, but seen it happen quite frequently on CI. This change is mostly a stab in the dark, but removes the code lines which make the issue to surface. |
Ack. I have seen it too after disabling that class loader check PR and reported it here |
@pvary thx for the explanation. let's give it a try then. if it still doesn't fix it, let's disable/ignore this test for now. |
@stevenzwu: Ahh.. I forgot to merge. Thanks for finding and merging this! |
Co-authored-by: Peter Vary <peter_vary4@apple.com>
Co-authored-by: Peter Vary <peter_vary4@apple.com>
Co-authored-by: Peter Vary <peter_vary4@apple.com>
No description provided.