Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs switch #9520

Merged
merged 1 commit into from
Jan 30, 2024
Merged

New docs switch #9520

merged 1 commit into from
Jan 30, 2024

Conversation

bitsondatadev
Copy link
Collaborator

@bitsondatadev bitsondatadev commented Jan 18, 2024

This PR moves us to the updated documentation project to bring the Iceberg website and documentation back to the main repository. Related PRs: #8659, #8912, #8917, and #8919.

  1. Revert adding the ASF site publish indicator from the apache/iceberg-docs repository. This step must happen first! Remove ASF publish property iceberg-docs#308

  2. Merge this PR:

    1. Update the deploy script to point to the asf-site branch instead of the default gh-pages branch.

    2. Revert removing the ASF site publish indicator from the apache/iceberg repository to indicate ASF infra that this repository's asf-site branch is now where the Iceberg site exists.

    3. Delete the current versioned ./docs and replace those from the current versioned docs location ./site/docs/docs/nightly/. (This is the majority of the file changes in this PR.

We will move the versioned docs under site/docs/docs/nightly/ and put them in the top-level docs folder. (#9578) This merge will happen afterwards to preserve the history of the versioned documentation in this folder. Stay tuned.

Fixes: #8151

@rdblue
Copy link
Contributor

rdblue commented Jan 28, 2024

@bitsondatadev, the changes to move over to the site under site and the changes to docs must be separate PRs. We have not yet fixed the nightly docs, so I think we should remove them.

@bitsondatadev
Copy link
Collaborator Author

bitsondatadev commented Jan 28, 2024

@bitsondatadev, the changes to move over to the site under site and the changes to docs must be separate PRs. We have not yet fixed the nightly docs, so I think we should remove them.

Yeah, I just didn't want to push this forward until we were this close. Let me pull those changes out into a separate PR today. That will make this final PR much less intimidating.

@bitsondatadev
Copy link
Collaborator Author

@rdblue I split out the directory changes: #9578

Now this PR merge just changes the site back.

@rdblue
Copy link
Contributor

rdblue commented Jan 29, 2024

@bitsondatadev, thanks! This looks more like what I was expecting! I'm +1 on this when the thread on the dev list concludes.

@bitsondatadev bitsondatadev changed the title [DO NOT MERGE] New docs switch New docs switch Jan 30, 2024
@bitsondatadev bitsondatadev marked this pull request as ready for review January 30, 2024 18:12
@rdblue rdblue merged commit ac46000 into apache:main Jan 30, 2024
41 checks passed
adnanhemani pushed a commit to adnanhemani/iceberg that referenced this pull request Jan 30, 2024
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems in release doc about versioned documentation
2 participants