Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-API: Add table updates for statistics #9564

Merged
merged 2 commits into from Feb 1, 2024

Conversation

mrcnc
Copy link
Contributor

@mrcnc mrcnc commented Jan 26, 2024

Table statistics were added in #5450 and it would be helpful to have them in the OpenAPI spec for REST catalog implementations that don't use the Java parsers from Iceberg.

- snapshot-id
- sequence-number
- fields
- properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

properties are optional

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but properties in BlobMetadata need to be removed from the required fields, as they are optional

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @mrcnc

@nastra nastra merged commit 974bde3 into apache:main Feb 1, 2024
3 checks passed
@mrcnc mrcnc deleted the add-statistics-operations-to-openapi-spec branch February 1, 2024 15:56
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants