Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add/update Snowflake #9669

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

scottteal
Copy link
Contributor

My last pull request wasn't merged before docs were switched, so submitting this one editing the correct files post-switch

Old PR: #9557

FYI @bitsondatadev

Add Snowflake and make it closer to alphabetical order, keeping open source toward the top, vendors toward the bottom
Include latest docs links
Copy link
Collaborator

@bitsondatadev bitsondatadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but actually brought up a question for me on the ordering of engines in the docs nav. I would suggest just removing the changes and we'll have a discussion around ordering.

docs/mkdocs.yml Outdated
Comment on lines 51 to 59
- Doris: https://doris.apache.org/docs/dev/lakehouse/multi-catalog/iceberg
- Impala: https://impala.apache.org/docs/build/html/topics/impala_iceberg.html
- Presto: https://prestodb.io/docs/current/connector/iceberg.html
- Dremio: https://docs.dremio.com/data-formats/apache-iceberg/
- Starrocks: https://docs.starrocks.io/en-us/latest/data_source/catalog/iceberg_catalog
- Trino: https://trino.io/docs/current/connector/iceberg.html
- Amazon Athena: https://docs.aws.amazon.com/athena/latest/ug/querying-iceberg.html
- Amazon EMR: https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-use-cluster.html
- Impala: https://impala.apache.org/docs/build/html/topics/impala_iceberg.html
- Doris: https://doris.apache.org/docs/dev/lakehouse/multi-catalog/iceberg
- Clickhouse: https://clickhouse.com/docs/en/engines/table-engines/integrations/iceberg
- Dremio: https://docs.dremio.com/data-formats/apache-iceberg/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new ordering confuses me a bit, I believe it's something to discuss as I believe it should just be alphanumeric.

@Fokko @RussellSpitzer @nastra @flyrain @ajantha-bhat, is there any reason we shouldn't just make these alphanumeric?

I believe Spark, Flink, and Trino have the most support and why they came first initially, but as this project grows, it's likely better we just follow alphanumeric everywhere. Unless we want to group engines by some metric of Iceberg support and then alphanumeric.

Let me know what you all think and if this should be a topic at the next sync.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphanumeric order makes sense to me. But it may mess up with other non-engine pages like Table, API. Should we introduce another top-level index to group all engines(Spark, Flink, Snowflake, PyIceberg, etc)?

Copy link
Collaborator

@bitsondatadev bitsondatadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottteal LGTM!

@danielcweeks danielcweeks merged commit 3b8fd90 into apache:main Feb 8, 2024
8 checks passed
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
* Update sidebar

Add Snowflake and make it closer to alphabetical order, keeping open source toward the top, vendors toward the bottom

* Update Snowflake's description

Include latest docs links

* Add Snowflake without disrupting ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants