fix after review

apache · Oct 12, 2023 · 56f811c · 56f811c
1 parent 6f78a2e
commit 56f811c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/...les/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RowConverter.java b/...les/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RowConverter.java
@@ -73,14 +73,9 @@ static <RowT> BinaryTuplePrefix toBinaryTuplePrefix(
 
         assert prefixColumnsCount == indexedColumnsCount : "Invalid range condition";
 
-        int rowColumnsCount = 0;
-        for (int i = 0; i < prefixColumnsCount; i++) {
-            if (unspecified.get(i)) {
-                break;
-            }
+        int pos = unspecified.nextSetBit(0);
 
-            rowColumnsCount++;
-        }
+        int rowColumnsCount = pos == -1 ? prefixColumnsCount : pos;
 
         BinaryTuplePrefixBuilder tupleBuilder = new BinaryTuplePrefixBuilder(rowColumnsCount, indexedColumnsCount);
 
@@ -118,7 +113,8 @@ private static <RowT> ByteBuffer toByteBuffer(
             BinaryTupleSchema binarySchema,
             RowHandler<RowT> handler,
             BinaryTupleBuilder tupleBuilder,
-            RowT searchRow, int colCount
+            RowT searchRow,
+            int colCount
     ) {
         for (int i = 0; i < colCount; i++) {
             Object val = handler.get(i, searchRow);

diff --git a/...e/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImpl.java b/...e/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImpl.java
@@ -92,11 +92,6 @@
 public class ExpressionFactoryImpl<RowT> implements ExpressionFactory<RowT> {
     private static final int CACHE_SIZE = 1024;
 
-    // We use enums for placeholders because enum serialization/deserialization guarantees to preserve object's identity.
-    private enum Placeholder {
-        UNSPECIFIED_VALUE
-    }
-
     private static final ConcurrentMap<String, Scalar> SCALAR_CACHE = Caffeine.newBuilder()
             .maximumSize(CACHE_SIZE)
             .<String, Scalar>build()