IGNITE-20600 Sql. Fix a message of an error, which occurs while updat…

…ing primary key column (#2695)
apache · Oct 18, 2023 · 7aa17fe · 7aa17fe
1 parent 7953fab
commit 7aa17fe
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java b/...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java
@@ -30,7 +30,7 @@ public interface IgniteResource {
     @Resources.BaseMessage("Illegal alias. {0} is reserved name")
     Resources.ExInst<SqlValidatorException> illegalAlias(String a0);
 
-    @Resources.BaseMessage("Cannot update field \"{0}\". You cannot update key, key fields or val field in case the val is a complex type")
+    @Resources.BaseMessage("Cannot update field \"{0}\". Primary key columns are not modifiable")
     Resources.ExInst<SqlValidatorException> cannotUpdateField(String field);
 
     @Resources.BaseMessage("Illegal aggregate function. {0} is unsupported at the moment")

diff --git a/...ql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/DmlPlannerTest.java b/...ql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/DmlPlannerTest.java
@@ -223,6 +223,36 @@ private static Stream<String> basicStatements() {
         );
     }
 
+    /**
+     * Tests that primary key columns are not modifiable.
+     */
+    @ParameterizedTest
+    @MethodSource("updatePrimaryKey")
+    public void testDoNotAllowToModifyPrimaryKeyColumns(String query) {
+        TestTable test = TestBuilders.table()
+                .name("TEST")
+                .addKeyColumn("ID", NativeTypes.INT32)
+                .addColumn("VAL", NativeTypes.INT32)
+                .distribution(IgniteDistributions.single())
+                .build();
+
+        IgniteSchema schema = createSchema(test);
+
+        IgniteTestUtils.assertThrowsWithCause(
+                () ->  physicalPlan(query, schema),
+                SqlValidatorException.class,
+                "Primary key columns are not modifiable"
+        );
+    }
+
+    private static Stream<String> updatePrimaryKey() {
+        return Stream.of(
+                "UPDATE TEST SET ID = ID + 1",
+                "MERGE INTO test DST USING test SRC ON DST.VAL = SRC.VAL"
+                        + " WHEN MATCHED THEN UPDATE SET ID = SRC.ID + 1"
+        );
+    }
+
     // Class name is fully-qualified because AbstractPlannerTest defines a class with the same name.
     private static TestTable newTestTable(String tableName, IgniteDistribution distribution) {
         return TestBuilders.table()