Ignite-17834 Fixed. #1168
Ignite-17834 Fixed. #1168
Conversation
Signed-off-by: alapin <lapin1702@gmail.com>
Signed-off-by: alapin <lapin1702@gmail.com>
| } catch (TransactionException enlistResultException) { | ||
| return tx0.rollbackAsync().handle((ignored, err) -> { | ||
| if (err != null) { | ||
| e.addSuppressed(err); |
| try { | ||
| tx0.enlistResultFuture(fut); | ||
| } catch (TransactionException enlistResultException) { | ||
| return tx0.rollbackAsync().handle((ignored, err) -> { |
There was a problem hiding this comment.
Why are you rolling back the transaction if it is already finished?
There was a problem hiding this comment.
Because it's required to cleanup locks and writeIntents for operation that failed to enlistResultFuture.
There was a problem hiding this comment.
So that will not happen because the transaction is already finished.
There was a problem hiding this comment.
You are right we need an escape path in order to rollback partially finished transaction.
| private final List<CompletableFuture<?>> enlistedResults = new ArrayList<>(); | ||
|
|
||
| /** Guard that prevents finishing or enlisting new operations into already finished or finishing transaction. */ | ||
| private boolean txInFinishState = false; |
There was a problem hiding this comment.
Way do not you want to make txInFinishState to AtomicBoolean and get rid of synchronized in the finish method?
There was a problem hiding this comment.
Because it's required not only to change txInFinishState atomically but also to populate enlistedResults with new value
public synchronized void enlistResultFuture(CompletableFuture<?> resultFuture) {
if (txInFinishState) {
throw new TransactionException(TX_ALREADY_FINISHED_ERR,
"Failed to enlist operation into already finished transaction txId={" + id + '}');
}
enlistedResults.add(resultFuture);
}
Signed-off-by: alapin <lapin1702@gmail.com>
This reverts commit 357e3f9. Signed-off-by: alapin <lapin1702@gmail.com> # Conflicts: # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
This reverts commit 357e3f9. Signed-off-by: alapin <lapin1702@gmail.com> # Conflicts: # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
Signed-off-by: alapin <lapin1702@gmail.com> Co-authored-by: sanpwc <alapin@gridgain.com>
Signed-off-by: alapin <lapin1702@gmail.com> Co-authored-by: sanpwc <alapin@gridgain.com>
Signed-off-by: alapin lapin1702@gmail.com