IGNITE-19093: Create standalone MetaStorage implementation for test purposes #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-19093
branch
from
60ef107
to
d771288
Compare
AMashenkov
force-pushed
the
ignite-19093
branch
from
02f5f02
to
3a95694
Compare
AMashenkov
force-pushed
the
ignite-19093
branch
from
8668d30
to
56faee6
Compare
sashapolo
reviewed
Mar 23, 2023
...tFixtures/java/org/apache/ignite/internal/metastorage/impl/StandaloneMetaStorageManager.java
Outdated
Show resolved
Hide resolved
...tFixtures/java/org/apache/ignite/internal/metastorage/impl/StandaloneMetaStorageManager.java
Outdated
Show resolved
Hide resolved
...tFixtures/java/org/apache/ignite/internal/metastorage/impl/StandaloneMetaStorageManager.java
Outdated
Show resolved
Hide resolved
...tFixtures/java/org/apache/ignite/internal/metastorage/impl/StandaloneMetaStorageManager.java
Outdated
Show resolved
Hide resolved
...tFixtures/java/org/apache/ignite/internal/metastorage/impl/StandaloneMetaStorageManager.java
Outdated
Show resolved
Hide resolved
...pache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java
Outdated
Show resolved
Hide resolved
...tFixtures/java/org/apache/ignite/internal/metastorage/impl/StandaloneMetaStorageManager.java
Outdated
Show resolved
Hide resolved
...pache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java
Outdated
Show resolved
Hide resolved
| mockVaultZonesLogicalTopologyKey(nodes); | ||
| // Mock logical topology for distribution zone. | ||
| // vaultMgr.put(zonesLogicalTopologyKey(), toBytes(nodes)); | ||
| keyValueStorage.put(zonesLogicalTopologyVersionKey().bytes(), longToBytes(1)); |
There was a problem hiding this comment.
I like the previous approach with mocking LogicalTopologyService more
There was a problem hiding this comment.
Seems, here is a race, or the test was incorrect from the very beginning.
https://issues.apache.org/jira/browse/IGNITE-19104
There was a problem hiding this comment.
vaultMgr = mock(VaultManager.class);
when(vaultMgr.get(any())).thenReturn(completedFuture(null));
CompletableFuture<VaultEntry> fut = new CompletableFuture<>();;
when(vaultMgr.get(zonesLogicalTopologyKey()))
.thenReturn(fut.completeAsync(
() -> new VaultEntry(zonesLogicalTopologyKey(), toBytes(nodes)),
CompletableFuture.delayedExecutor(1, TimeUnit.SECONDS)));
Test fails if we delay future completion.
That means DistributedZoneManager make some interactions with other components, that are not tested well.
There was a problem hiding this comment.
I've reverted to the previous approach.
Looks fine.
sashapolo
reviewed
Mar 23, 2023
...pache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java
Outdated
Show resolved
Hide resolved
...pache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19093