IGNITE-19212 ODBC: Implement basic query execution #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isapego
commented
Jul 4, 2023
isapego
commented
- Ported basic query execution functionality from Ignite 2;
- Ported tests;
- Adapted to use new protocol;
ptupitsyn
requested changes
Jul 4, 2023
| @@ -154,15 +154,15 @@ class result_set_impl : public std::enable_shared_from_this<result_set_impl> { | |||
| * | |||
| * @return @c true if there are more pages with results and @c false otherwise. | |||
| */ | |||
| [[nodiscard]] IGNITE_API bool has_more_pages() { return m_resource_id.has_value() && m_has_more_pages; } | |||
| [[nodiscard]] bool has_more_pages() { return m_resource_id.has_value() && m_has_more_pages; } | |||
There was a problem hiding this comment.
Is IGNITE_API removed because this is _imp.h?
There was a problem hiding this comment.
Yeah, those methods should not be in API
ptupitsyn
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.