IGNITE-14865 Improve error handling in SQL module. #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
force-pushed
the
ignite-14865
branch
4 times, most recently
from
6f15d97
to
aa72941
Compare
xtern
changed the title
xtern
force-pushed
the
ignite-14865
branch
5 times, most recently
from
6c5d9c4
to
4c7ce41
Compare
xtern
force-pushed
the
ignite-14865
branch
3 times, most recently
from
4ed156f
to
ccfd549
Compare
...r/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Jul 31, 2023
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Jul 31, 2023
...sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExchangeServiceImpl.java
Outdated
Show resolved
Hide resolved
xtern
force-pushed
the
ignite-14865
branch
3 times, most recently
from
21ce4ab
to
d8060b4
Compare
xtern
force-pushed
the
ignite-14865
branch
4 times, most recently
from
6f3cab9
to
49b30e4
Compare
…ates to internal." This reverts commit 41be603.
AMashenkov
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-14865
We have two main entry points in the SQL module for all public API
AsyncSqlCursorImpl#requestNextAsyncSqlQueryProcessor#querySingleAsyncrequestNextAsync converts internal exceptions to public by itself.
querySingleAsync, cannot translate internal exceptions because SessionImpl#execAsync (and others) handles an internal
SessionNotFoundExceptionthat currently has no public equivalent (or at least separate sql code).So for querySingleAsync exception mapping is made in 3 places
(right after
SessionNotFoundExceptionhandling):SessionImpl#executeAsyncSessionImpl#executeBatchAsyncJdbcConnectionContext#doInSessionWe also have a
RemoteFragmentExecutionExceptionwhich must have a valid traceId and error code, so we convert the internal exception to public and sending traceId and error code inExchangeServiceImpl#sendError. Those. in this case the exception is converted twice. First time on the remote host, and then the resultingRemoteFragmentExecutionExceptionconverts into aSqlExceptionwith specified error code.