Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-20148 Explicit writeIntent cleanup on primary replica #2405

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

sanpwc
Copy link
Contributor

@sanpwc sanpwc commented Aug 3, 2023

https://issues.apache.org/jira/browse/IGNITE-20148

Thank you for submitting the pull request.

In order to streamline the review of the patch and ensure better code quality
we ask both an author and a reviewer to check the following requirements:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also check the following list:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT and WHY was made and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into a smaller pieces, its size is reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: tests set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@sanpwc sanpwc marked this pull request as ready for review August 3, 2023 15:41
@sanpwc sanpwc merged commit 3e15298 into apache:main Aug 4, 2023
1 check passed
@sanpwc sanpwc deleted the ignite-20148 branch August 4, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants