Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-20346 ODBC: Implement column metadata fetching #2650

Merged
merged 10 commits into from
Oct 3, 2023
Merged

IGNITE-20346 ODBC: Implement column metadata fetching #2650

merged 10 commits into from
Oct 3, 2023

Conversation

isapego
Copy link
Contributor

@isapego isapego commented Oct 3, 2023

  • Ported code from Ignite 2;
  • Adjusted to Calcite. Fixed some issues found in the process;
  • Un-commented tests;
  • Updated DEVNOTES.md.

@isapego isapego requested a review from ptupitsyn October 3, 2023 02:20
ptupitsyn
ptupitsyn approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ptupitsyn ptupitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general; please see a couple of minor comments.

modules/platforms/cpp/ignite/odbc/query/column_metadata_query.h Outdated Show resolved Hide resolved
modules/platforms/cpp/ignite/odbc/type_traits.cpp Outdated Show resolved Hide resolved
@isapego isapego merged commit 82d46f4 into apache:main Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptupitsyn ptupitsyn ptupitsyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@isapego @ptupitsyn