-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-21497 Clarify compute API #3190
Conversation
05c507c
to
69bf9a0
Compare
7a6785a
to
0f395ea
Compare
0f395ea
to
554470c
Compare
* @param <R> Job result type. | ||
* @return Job result future. | ||
*/ | ||
default <R> CompletableFuture<R> executeColocatedAsync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitColocatedAsync?
* @param <R> Job result type. | ||
* @return Job result future. | ||
*/ | ||
default <R> CompletableFuture<R> executeColocatedAsync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooohh, it calles .resultAsync()
. Can you mention that in the method javadoc??
# Conflicts: # modules/platforms/dotnet/Apache.Ignite.Tests/Compute/ComputeTests.cs
https://issues.apache.org/jira/browse/IGNITE-21497
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes