IGNITE-21390 Inconsistent behavior of Compute APIs when target node does not exist #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valepakh
force-pushed
the
IGNITE-21390
branch
from
d975745
to
273043c
Compare
ptupitsyn
requested changes
Feb 8, 2024
Comment on lines
111
to
115
| for (ClusterNode node : nodes) { | ||
| if (topologyService.getByConsistentId(node.name()) == null) { | ||
| return new FailedExecution<>(new NodeNotFoundException(node.name())); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we should not fail if at least one specified node is present. Otherwise the user has to wrap all compute API calls into a retry loop because node failure is always possible.
| * Thrown when compute component can't find the node to run the job on in the cluster. | ||
| */ | ||
| public class NodeNotFoundException extends ComputeException { | ||
|
|
| @@ -493,6 +498,49 @@ void testExecuteColocatedOnUnknownUnitWithLatestVersionThrows() { | |||
| assertEquals(INTERNAL_ERR, cause.code()); | |||
| } | |||
|
|
|||
| @Test | |||
| void executeAsyncThrowsErrorWhenNodeIsNotFound() { | |||
There was a problem hiding this comment.
It would be great to have a single test that runs against embedded and thin client APIs to ensure consistent behavior, like we do with ItAbstractDataStreamerTest or ItSqlApiBaseTest.
valepakh
force-pushed
the
IGNITE-21390
branch
2 times, most recently
from
7be7e8d
to
8475edb
Compare
valepakh
force-pushed
the
IGNITE-21390
branch
from
8475edb
to
d239599
Compare
|
I changed the behavior to throw only when there are no candidate nodes. For some reason C++ test for synchronous broadcast doesn't work. |
ptupitsyn
reviewed
Feb 12, 2024
...main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java
Outdated
Show resolved
Hide resolved
ptupitsyn
requested changes
Feb 12, 2024
...ute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeErrorsBaseTest.java
Show resolved
Hide resolved
modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeJobFailover.java
Outdated
Show resolved
Hide resolved
...mpute/src/main/java/org/apache/ignite/internal/compute/exceptions/NodeNotFoundException.java
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Tests/Compute/ComputeTests.cs
Outdated
Show resolved
Hide resolved
valepakh
commented
Feb 12, 2024
| EXPECT_THROW( | ||
| { | ||
| try { | ||
| m_client.get_compute().broadcast({unknown_node}, {}, ECHO_JOB, {"unused"}); |
There was a problem hiding this comment.
@isapego It seems that the broadcast_async doesn't propagate exceptions thrown from the execute_on_nodes, could you please take a look and see if it's possible to have this test here?
ptupitsyn
approved these changes
Feb 19, 2024
...mpute/src/integrationTest/java/org/apache/ignite/internal/compute/utils/InteractiveJobs.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-21390
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes