Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-21815 Client handler: use QueryProcessor instead of IgniteSql #3459

Merged
merged 36 commits into from Mar 21, 2024

Conversation

ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Mar 21, 2024

Use internal QueryProcessor API in client handler instead of public IgniteSql:

https://issues.apache.org/jira/browse/IGNITE-21815

@ptupitsyn ptupitsyn self-assigned this Mar 21, 2024
@ptupitsyn ptupitsyn requested a review from korlov42 March 21, 2024 09:08
@ptupitsyn ptupitsyn marked this pull request as ready for review March 21, 2024 09:08
Copy link
Contributor

@korlov42 korlov42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -41,6 +41,7 @@
* Asynchronous result set implementation.
*/
public class AsyncResultSetImpl<T> implements AsyncResultSet<T> {
@Nullable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ptupitsyn ptupitsyn merged commit cbc84eb into apache:main Mar 21, 2024
1 check passed
@ptupitsyn ptupitsyn deleted the ignite-21815 branch March 21, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants