IGNITE-22086 Thin client: initialize observableTimestamp in handshake #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
changed the title
isapego
requested changes
Apr 30, 2024
| @@ -261,6 +261,7 @@ class node_connection : public std::enable_shared_from_this<node_connection> { | |||
|
|
|||
| /** Configuration. */ | |||
| const ignite_client_configuration &m_configuration; | |||
| void on_observable_timestamp_changed(int64_t observable_timestamp) const; | |||
There was a problem hiding this comment.
This has to be moved upper, to methods section, and given some simple description.
isapego
approved these changes
Apr 30, 2024
AMashenkov
pushed a commit
that referenced
this pull request
May 14, 2024
…#3679) Before this fix we propagated `observableTimestamp` to the client with every response, but not on handshake. As a result, the very first operation from the client has `observableTimestamp = 0`, which can lead to causality issues. Fix Java, .NET, C++ clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix we propagated
observableTimestampto the client with every response, but not on handshake. As a result, the very first operation from the client hasobservableTimestamp = 0, which can lead to causality issues.Fix Java, .NET, C++ clients.