IGNITE-20645 Make ComputeJob.execute asynchronous #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isapego
approved these changes
Jun 14, 2024
| public interface ComputeJob<R> { | ||
| /** | ||
| * Executes the job on an Ignite node. | ||
| * | ||
| * @param context The execution context. | ||
| * @param args Job arguments. | ||
| * @return Job result. | ||
| * @return Job future. Can be null if the job is synchronous and does not return any result. |
There was a problem hiding this comment.
- Very small performance improvement
- A bit easier for the user at the expense of a one-line check in Ignite code
Do you think we should disallow nulls?
Pochatkin
reviewed
Jun 14, 2024
| public interface ComputeJob<R> { | ||
| /** | ||
| * Executes the job on an Ignite node. | ||
| * | ||
| * @param context The execution context. | ||
| * @param args Job arguments. | ||
| * @return Job result. | ||
| * @return Job future. Can be null if the job is synchronous and does not return any result. |
There was a problem hiding this comment.
Do we really want to have Nullable futute? Mby in this case user should have CF ?
There was a problem hiding this comment.
Same question from @isapego above. I don't have a strong opinion, we can require a non-null future.
user should have CF
CF?
There was a problem hiding this comment.
The user can return completedFuture() or null, it does not make any difference. Let's keep it this way.
...pute/src/main/java/org/apache/ignite/internal/compute/state/InMemoryComputeStateMachine.java
Outdated
Show resolved
Hide resolved
...mpute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java
Outdated
Show resolved
Hide resolved
...mpute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java
Outdated
Show resolved
Hide resolved
...mpute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
valepakh
reviewed
Jun 14, 2024
| @@ -93,7 +93,8 @@ public TaskExecutionInternal( | |||
| splitExecution = executorService.submit( | |||
| () -> { | |||
| MapReduceTask<R> task = instantiateTask(taskClass); | |||
| return new SplitResult<>(task, task.split(context, args)); | |||
|
|
|||
| return completedFuture(new SplitResult<>(task, task.split(context, args))); | |||
There was a problem hiding this comment.
Should we also make MapReduceTask.split and reduce asynchronous?
There was a problem hiding this comment.
valepakh
reviewed
Jun 17, 2024
.../apache/ignite/client/handler/requests/table/ClientStreamerWithReceiverBatchSendRequest.java
Outdated
Show resolved
Hide resolved
.../apache/ignite/client/handler/requests/table/ClientStreamerWithReceiverBatchSendRequest.java
Outdated
Show resolved
Hide resolved
modules/client/src/test/java/org/apache/ignite/client/fakes/FakeCompute.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
Outdated
Show resolved
Hide resolved
valepakh
approved these changes
Jun 17, 2024
# Conflicts: # modules/compute/src/test/java/org/apache/ignite/internal/compute/executor/ComputeExecutorTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R ComputeJob.execute(...)toCompletableFuture<R> ComputeJob.executeAsync(...)