IGNITE-15581 add proper handling of errors in user's state machines #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alievmirza
force-pushed
the
ignite-15581
branch
from
80ec5c3
to
9630ac9
Compare
vldpyatkov
reviewed
Nov 1, 2021
| */ | ||
| @Test | ||
| public void testRangeNextNoSuchElementException() { | ||
| when(mockStorage.range(EXPECTED_RESULT_ENTRY.key().bytes(), null)).thenAnswer(invocation -> { |
There was a problem hiding this comment.
Why can't get NoSuchElementException honestly? (Iterate until a cursor finished)
There was a problem hiding this comment.
this is a valid case when the cursor on the server side is not found, for example
| * that throwable will be changed to a more compact structure, containing only message. Note, that | ||
| * in case of compaction, corresponding throwable must be in classpath on a client side. | ||
| */ | ||
| void failure(Throwable th, boolean compacted); |
There was a problem hiding this comment.
Parameter compacted seems doubt to me.
Because it is a technical field it depends of some internal configuration (need stack on client of not, may be due to debug level). I do not wont to see this argument in the API.
alievmirza
force-pushed
the
ignite-15581
branch
from
8cdb02b
to
696887f
Compare
vldpyatkov
reviewed
Nov 2, 2021
|
|
||
| fut.completeExceptionally(restoredTh); | ||
| } | ||
| catch (Exception e) { |
There was a problem hiding this comment.
Can you write a warning here?
"The exception does not have a constructor with a string message, IgniteException will be use."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-15581