IGNITE-14830 Introduce index internal API #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 15, 2021 11:15
# Conflicts: # modules/table/src/main/java/org/apache/ignite/internal/table/TableImpl.java # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
AMashenkov
reviewed
Dec 27, 2021
...ite/src/main/java/org/apache/ignite/internal/processors/query/calcite/SqlQueryProcessor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
...te/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteIndex.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
...c/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
modules/index/src/main/java/org/apache/ignite/internal/idx/InternalSortedIndexImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
modules/index/src/main/java/org/apache/ignite/internal/idx/InternalSortedIndexImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
| List<String> tblColIds = new ArrayList<>(tbl.schemaView().schema().columnNames()); | ||
| Set<String> idxColIds = columns().stream().map(Column::name).collect(Collectors.toSet()); | ||
|
|
||
| boolean needLookup = proj.stream().anyMatch(order -> !idxColIds.contains(tblColIds.get(order))); |
There was a problem hiding this comment.
Suggested change
| boolean needLookup = proj.stream().anyMatch(order -> !idxColIds.contains(tblColIds.get(order))); | |
| boolean indexOnly = proj.stream().map(tblColIds::get).allMatch(idxColIds::contains); |
Or better avoid streams.
AMashenkov
reviewed
Dec 27, 2021
modules/index/src/main/java/org/apache/ignite/internal/idx/InternalSortedIndexImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
...s/runner/src/integrationTest/java/org/apache/ignite/internal/calcite/ItMixedQueriesTest.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexBinaryRow.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRow.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRow.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
...storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRowDeserializer.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Dec 27, 2021
...torage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexSchemaDescriptor.java
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index-api/src/main/java/org/apache/ignite/internal/idx/IndexManager.java
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index-api/src/main/java/org/apache/ignite/internal/idx/InternalSortedIndex.java
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index-api/src/main/java/org/apache/ignite/internal/idx/SortedIndexDescriptor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index-api/src/main/java/org/apache/ignite/internal/idx/SortedIndexDescriptor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index/src/main/java/org/apache/ignite/internal/idx/IndexManagerImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index/src/main/java/org/apache/ignite/internal/idx/IndexManagerImpl.java
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index/src/main/java/org/apache/ignite/internal/idx/IndexManagerImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 3, 2022
modules/index/src/main/java/org/apache/ignite/internal/idx/IndexManagerImpl.java
Show resolved
Hide resolved
…/SortedIndexDescriptor.java Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com>
…/SortedIndexDescriptor.java Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com>
# Conflicts: # modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java # modules/table/src/main/java/org/apache/ignite/internal/table/TableImpl.java
AMashenkov
reviewed
Feb 4, 2022
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 4, 2022
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 4, 2022
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 4, 2022
.../sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RuntimeSortedIndex.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 4, 2022
...l-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 4, 2022
...l-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/InternalIgniteTable.java
Outdated
Show resolved
Hide resolved
AMashenkov
approved these changes
Feb 7, 2022
korlov42
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Feb 23, 2022
ygerzhedovich
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.