IGNITE-17100 Make JoinReady command idempotent #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpuch
reviewed
Jun 3, 2022
|
|
||
| assertThat(service.completeJoinCluster(), willCompleteSuccessfully()); | ||
|
|
||
| assertThat(service.completeJoinCluster(), willCompleteSuccessfully()); |
There was a problem hiding this comment.
Why is completion tried 3 times, while start is only tried 2 times?
There was a problem hiding this comment.
I just wanted to verify that there's no state behind the start, so I execute the completion phase 1 time more
| assertThat(service.completeJoinCluster(), willCompleteSuccessfully()); | ||
|
|
||
| assertThat(service.completeJoinCluster(), willCompleteSuccessfully()); | ||
| } |
There was a problem hiding this comment.
Does it make sense to also check how startJoinCluster() works AFTER completeJoinCluster()?
There was a problem hiding this comment.
I don't know, it shouldn't happen in a normal case scenario...
rpuch
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-17100