Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-17098 - Added info on pluggable storage #856

Closed
wants to merge 5 commits into from

Conversation

IgGusev
Copy link
Contributor

@IgGusev IgGusev commented Jun 6, 2022

No description provided.

@@ -33,10 +33,12 @@ Parameters:
* `tableColumn` - name and type of a column to be created in the new table.
* `DEFAULT` - specifies a default value for the column. Only constant values are accepted.
* `IF NOT EXISTS` - create the table only if a table with the same name does not exist.
* `ENGINE` - sets the storage engine to use. Currently: `pagememory` or `rocksdb`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a set, it should be single particular engine

@@ -33,10 +33,12 @@ Parameters:
* `tableColumn` - name and type of a column to be created in the new table.
* `DEFAULT` - specifies a default value for the column. Only constant values are accepted.
* `IF NOT EXISTS` - create the table only if a table with the same name does not exist.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `IF NOT EXISTS` - create the table only if a table with the same name does not exist.
* `IF NOT EXISTS` - create the table only if a table with the same name does not exist.
* `COLOCATED BY` - XXXXXXXXXXXXXX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update schema at 26 line by adding

[COLOCATE [BY] (tableColumn [, tableColumn]...)]
[ENGINE engineName]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@IgGusev IgGusev closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants