IGNITE-12358 Migrate ZeroMQ module to ignite-extensions #5
Conversation
modules/zeromq-ext/pom.xml
Outdated
| <ignite-core.version>2.9.0-SNAPSHOT</ignite-core.version> | ||
| <ignite-log4j.version>2.9.0-SNAPSHOT</ignite-log4j.version> | ||
| <ignite-spring.version>2.9.0-SNAPSHOT</ignite-spring.version> |
There was a problem hiding this comment.
it should be a single ignite.version, we do not need to have a separate version for each jar.
Furthermore, why do we have it here? I think it should be defined in parent pom, so all extensions will be built and release for the same ignite version. However, if we want to treat all extensions as absolutely independent unites and each one can support different ignite versions, then why we put all extensions under a single umbrella project?
There was a problem hiding this comment.
@Mikhail1988 I have updated the PR to have single ignite.version.
The plan is to only release each extension if they need to be updated based on latest ignite.version. This will help us reduce number of extension releases every ignite version release. We do need to certify and test that existing extension does not break with any new changes.
modules/zeromq-ext/README.txt
Outdated
| <dependencies> | ||
| ... | ||
| <dependency> | ||
| <groupId>org.apache.ignite</groupId> | ||
| <artifactId>ignite-zeromq</artifactId> | ||
| <version>${ignite.version}</version> | ||
| </dependency> | ||
| ... | ||
| </dependencies> |
There was a problem hiding this comment.
it's not true anymore and needs to be fixed.
but I like idea to match extension version and ignite version, so let's replace 1.0.0-SNAPSHOT with ignite version 2.9.0-SNAPSHOT.
|
|
||
| # node01 signed with trust-one, node02 and node03 by trust-two, node02old is expired | ||
| # trust-both contains both CAs | ||
| ssl.keystore.node01.path=@{IGNITE_HOME}/modules/clients/src/test/keystore/ca/node01.jks |
There was a problem hiding this comment.
Do we need all of these properties here? These files are not reachable from ignite-extensions
There was a problem hiding this comment.
yes, I had initially put it under ignite-extensions path but the tests were failing. So, I had put it in a locally resolvable path.
| @@ -44,6 +44,7 @@ | |||
| <modules> | |||
| <module>modules/flink-ext</module> | |||
| <module>modules/pub-sub</module> | |||
| <module>modules/zeromq-ext</module> | |||
There was a problem hiding this comment.
Do we really need to add -ext to all of those modules' names?
There was a problem hiding this comment.
I had put ext to avoid conflict with existing released version. As we are planning to release from 1.0.0 version.
No description provided.